Remove `Symbol` from `Named` variant of `BoundRegionKind`/`LateParamRegionKind` #139598

compiler-errors · 2025-04-09T20:05:03Z

The Symbol is redundant, since we already store a DefId in the region variant. Instead, load the name via item_name when needed (which is almost always on the diagnostic path).

This introduces a BoundRegionKind::NamedAnon which is used for giving anonymous bound regions names, but which should only be used during pretty printing and error reporting.

compiler-errors · 2025-04-09T20:05:09Z

@bors try @rust-timer queue

… r=<try> Remove `Symbol` from `Named` variant of `BoundRegionKind`/`LateParamRegionKind` r? `@ghost`

bors · 2025-04-09T20:06:22Z

⌛ Trying commit dba712a with merge 098a24f...

bors · 2025-04-09T22:04:09Z

☀️ Try build successful - checks-actions
Build commit: 098a24f (098a24f333aac968a2fcbf1e3d152550224ea44d)

rust-timer · 2025-04-10T04:42:34Z

Finished benchmarking commit (098a24f): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.1%, 0.3%]	4
Regressions ❌ (secondary)	0.3%	[0.2%, 0.4%]	12
Improvements ✅ (primary)	-0.2%	[-0.5%, -0.1%]	54
Improvements ✅ (secondary)	-0.3%	[-0.6%, -0.1%]	37
All ❌✅ (primary)	-0.2%	[-0.5%, 0.3%]	58

Max RSS (memory usage)

Results (primary -0.4%, secondary -0.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.2%	[0.9%, 3.5%]	2
Regressions ❌ (secondary)	3.4%	[1.8%, 4.6%]	3
Improvements ✅ (primary)	-2.1%	[-2.6%, -1.5%]	3
Improvements ✅ (secondary)	-3.3%	[-3.9%, -2.1%]	4
All ❌✅ (primary)	-0.4%	[-2.6%, 3.5%]	5

Cycles

Results (primary 0.6%, secondary 1.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.3%	[1.0%, 1.6%]	3
Regressions ❌ (secondary)	1.4%	[1.4%, 1.4%]	1
Improvements ✅ (primary)	-1.4%	[-1.4%, -1.4%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.6%	[-1.4%, 1.6%]	4

Binary size

Results (primary -0.1%, secondary -0.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.3%, -0.0%]	118
Improvements ✅ (secondary)	-0.2%	[-0.8%, -0.0%]	33
All ❌✅ (primary)	-0.1%	[-0.3%, -0.0%]	118

Bootstrap: 780.203s -> 780.55s (0.04%)
Artifact size: 366.14 MiB -> 366.17 MiB (0.01%)

bors · 2025-05-06T02:29:41Z

☔ The latest upstream changes (presumably #140682) made this pull request unmergeable. Please resolve the merge conflicts.

compiler-errors · 2025-06-25T17:56:36Z

This is ready to review I think.

rustbot · 2025-06-25T17:56:40Z

r? @WaffleLapkin

rustbot has assigned @WaffleLapkin.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-06-25T17:56:41Z

HIR ty lowering was modified

cc @fmease

compiler-errors · 2025-06-25T18:01:05Z

@rustbot author

bors · 2025-06-27T01:16:44Z

☔ The latest upstream changes (presumably #143057) made this pull request unmergeable. Please resolve the merge conflicts.

WaffleLapkin · 2025-06-27T19:08:37Z

@compiler-errors is S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. still correct?

compiler-errors · 2025-06-27T19:09:22Z

naur

@rustbot ready

bors · 2025-06-27T19:55:10Z

☔ The latest upstream changes (presumably #143091) made this pull request unmergeable. Please resolve the merge conflicts.

WaffleLapkin

r=me with/out nits

WaffleLapkin · 2025-07-02T15:15:51Z

compiler/rustc_hir_analysis/src/collect.rs

-            } else {
-                None
-            }
+            if let Some(name) = lt.get_name(tcx) { Some(name.as_str().to_string()) } else { None }


nit: this would probably be more readable with .map()

WaffleLapkin · 2025-07-02T15:21:06Z

compiler/rustc_middle/src/ty/region.rs

            Some(name) => name,
            None => sym::anon,
        }
    }

    /// Is this region named by the user?
-    pub fn has_name(self) -> bool {
+    pub fn has_name(self, tcx: TyCtxt<'tcx>) -> bool {


Is there a reason why you renamed EarlyParamRegion::has_name to is_named, but not this?

nope :) i just forgor

they should all have the same name i think

WaffleLapkin · 2025-07-02T15:25:35Z

...ler/rustc_trait_selection/src/error_reporting/infer/nice_region_error/named_anon_conflict.rs

-                /* not an anonymous region */
-                debug!("try_report_named_anon_conflict: not an anonymous region");
-                return None;
-            }
+        if !anon_param_info.kind.is_named(self.tcx()) {
+            // Anon region
+        } else {
+            /* not an anonymous region */
+            debug!("try_report_named_anon_conflict: not an anonymous region");
+            return None;
        }


nit: swapping the branches would be more readable I think

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 9, 2025

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 9, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 9, 2025

Auto merge of rust-lang#139598 - compiler-errors:no-bound-var-symbol,…

098a24f

… r=<try> Remove `Symbol` from `Named` variant of `BoundRegionKind`/`LateParamRegionKind` r? `@ghost`

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Apr 10, 2025

compiler-errors force-pushed the no-bound-var-symbol branch from dba712a to b749895 Compare April 11, 2025 04:26

rustbot added the WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) label Apr 11, 2025

This comment has been minimized.

Sign in to view

compiler-errors force-pushed the no-bound-var-symbol branch from b749895 to 20eebb2 Compare June 25, 2025 17:07

compiler-errors marked this pull request as ready for review June 25, 2025 17:56

rustbot assigned WaffleLapkin Jun 25, 2025

This comment has been minimized.

Sign in to view

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2025

compiler-errors force-pushed the no-bound-var-symbol branch from 20eebb2 to 69c5275 Compare June 25, 2025 22:32

compiler-errors added 4 commits June 27, 2025 16:45

Remove Symbol for Named LateParam/Bound variants

fe1c8b3

Same for types

7fd1345

Fix pretty printing of placeholder types

424ac5a

Fix elided lifetimes in rustdoc

43b2648

compiler-errors force-pushed the no-bound-var-symbol branch from 69c5275 to 43b2648 Compare June 27, 2025 16:46

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 27, 2025

WaffleLapkin approved these changes Jul 2, 2025

View reviewed changes

WaffleLapkin added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 2, 2025

Remove Symbol from Named variant of BoundRegionKind/LateParamRegionKind #139598

Are you sure you want to change the base?

Remove Symbol from Named variant of BoundRegionKind/LateParamRegionKind #139598

Uh oh!

Conversation

compiler-errors commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

compiler-errors commented Apr 9, 2025

Uh oh!

This comment has been minimized.

bors commented Apr 9, 2025

Uh oh!

This comment has been minimized.

bors commented Apr 9, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Apr 10, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Uh oh!

This comment has been minimized.

bors commented May 6, 2025

Uh oh!

compiler-errors commented Jun 25, 2025

Uh oh!

rustbot commented Jun 25, 2025

Uh oh!

rustbot commented Jun 25, 2025

Uh oh!

This comment has been minimized.

compiler-errors commented Jun 25, 2025

Uh oh!

bors commented Jun 27, 2025

Uh oh!

WaffleLapkin commented Jun 27, 2025

Uh oh!

compiler-errors commented Jun 27, 2025

Uh oh!

bors commented Jun 27, 2025

Uh oh!

WaffleLapkin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Remove `Symbol` from `Named` variant of `BoundRegionKind`/`LateParamRegionKind` #139598

Remove `Symbol` from `Named` variant of `BoundRegionKind`/`LateParamRegionKind` #139598

compiler-errors commented Apr 9, 2025 •

edited

Loading